DP-44544 Fix-bug-in-advanced-search-for-documents-view#3252
Open
dstorozhuk wants to merge 16 commits intodevelopfrom
Open
DP-44544 Fix-bug-in-advanced-search-for-documents-view#3252dstorozhuk wants to merge 16 commits intodevelopfrom
dstorozhuk wants to merge 16 commits intodevelopfrom
Conversation
…nd revise pagination settings Integrated `better_exposed_filters` module into the `all_documents_latest_rev` view. Switched exposed form type to `bef`, revised pager to use full pagination with first/last links, and configured additional filter options to enhance search usability. Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
…for parent organizations without children Resolved issue with `INNER JOIN` on `node__field_organizations` that excluded parent organizations without child organizations by changing the join type to `LEFT`. Added a reflection-based adjustment to modify the query behavior dynamically. Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
…ove code clarity Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
- Fix duplicate rows caused by LEFT JOIN to multi-value organizations field - Added delta=0 condition to join only first organization per media - Eliminated ~29,576 duplicate rows (468,929 → 439,353 total) - Add Views Bulk Operations (VBO) functionality - Added bulk selection checkboxes to table - Enabled actions: Publish, Unpublish, Bulk Edit, Delete - Configured for 10 items per batch with form step - Changed distinct: true to false in view config - DISTINCT didn't work with multi-value fields - Fixed via join condition instead Technical changes: - Modified hook_views_query_alter() in mass_views.module - Updated views.view.all_documents_latest_rev.yml - Added module dependencies: views_bulk_operations, views_data_export Tested with 100 results - zero duplicates confirmed.
- Remove trailing whitespace on lines 284 and 414 - Fixes Squiz.WhiteSpace.SuperfluousWhitespace.EndLine violations
Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
a6c6647 to
a6d9946
Compare
49fd695 to
a6d9946
Compare
…anced search - Removed redundant code for handling duplicate rows caused by multi-value fields. - Introduced a container-aware approach in `OrgFilterMedia` to manage joins more effectively. - Updated `all_documents_latest_rev` view configuration to use the new `media_org_filter`. - Ensured join adjustments are processed via dependency injection for improved maintainability. - Adjusted cache metadata to avoid stale results. Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
…ch-for-documents-view * develop: revert 42778 and update the fields description (#3263) DP-44755: Clamav Debug mode (#3259) DP-44722: For collection pages, include the org search in the top search bar (#3260) changelog update and remove old changelog files DP-44176 Change-the-MySQL-version-in-CircleCI-in-ddev-to-match-the-db-version-in-on-Acquia (#3227)
…encies and fix organization filters - Removed `better_exposed_filters` module dependency from `all_documents_latest_rev` view. - Replaced `OrgTopParentFilter` implementation with a more robust `media_org_filter`. - Fixed joins for organization filters to improve query accuracy and performance. - Added revisions and ID fields to enhance filtering and display functionality. Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
…clarity Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
…mprove filter usability - Added `delta = 0` condition to LEFT JOIN for `field_organizations` in query alter to eliminate duplicate rows. - Updated exposed form type to `input_required` and added guidance text for filters. - Improved query and filter behavior for advanced search functionality. Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Explain the technical implementation of the work done.
Jira: (Skip unless you are MA staff)
DP-****
To Test:
Peer Review Checklist